Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement flake8-bandit rule
S108 (#1644)
- Loading branch information
1 parent
30d6688
commit 2f71bdf
Showing
18 changed files
with
354 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # ok | ||
| with open("/abc/tmp", "w") as f: | ||
| f.write("def") | ||
|
|
||
| with open("/tmp/abc", "w") as f: | ||
| f.write("def") | ||
|
|
||
| with open("/var/tmp/123", "w") as f: | ||
| f.write("def") | ||
|
|
||
| with open("/dev/shm/unit/test", "w") as f: | ||
| f.write("def") | ||
|
|
||
| # not ok by config | ||
| with open("/foo/bar", "w") as f: | ||
| f.write("def") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| use rustpython_ast::Expr; | ||
|
|
||
| use crate::ast::types::Range; | ||
| use crate::registry::{Check, CheckKind}; | ||
|
|
||
| /// S108 | ||
| pub fn hardcoded_tmp_directory(expr: &Expr, value: &str, prefixes: &[String]) -> Option<Check> { | ||
| if prefixes.iter().any(|prefix| value.starts_with(prefix)) { | ||
| Some(Check::new( | ||
| CheckKind::HardcodedTempFile(value.to_string()), | ||
| Range::from_located(expr), | ||
| )) | ||
| } else { | ||
| None | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| //! Settings for the `flake8-bandit` plugin. | ||
|
|
||
| use ruff_macros::ConfigurationOptions; | ||
| use schemars::JsonSchema; | ||
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| fn default_tmp_dirs() -> Vec<String> { | ||
| ["/tmp", "/var/tmp", "/dev/shm"] | ||
| .map(std::string::ToString::to_string) | ||
| .to_vec() | ||
| } | ||
|
|
||
| #[derive( | ||
| Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, JsonSchema, | ||
| )] | ||
| #[serde( | ||
| deny_unknown_fields, | ||
| rename_all = "kebab-case", | ||
| rename = "Flake8BanditOptions" | ||
| )] | ||
| pub struct Options { | ||
| #[option( | ||
| default = "[\"/tmp\", \"/var/tmp\", \"/dev/shm\"]", | ||
| value_type = "Vec<String>", | ||
| example = "hardcoded-tmp-directory = [\"/foo/bar\"]" | ||
| )] | ||
| /// A list of directories to consider temporary. | ||
| pub hardcoded_tmp_directory: Option<Vec<String>>, | ||
| #[option( | ||
| default = "[]", | ||
| value_type = "Vec<String>", | ||
| example = "extend-hardcoded-tmp-directory = [\"/foo/bar\"]" | ||
| )] | ||
| /// A list of directories to consider temporary, in addition to those | ||
| /// specified by `hardcoded-tmp-directory`. | ||
| pub hardcoded_tmp_directory_extend: Option<Vec<String>>, | ||
| } | ||
|
|
||
| #[derive(Debug, Hash)] | ||
| pub struct Settings { | ||
| pub hardcoded_tmp_directory: Vec<String>, | ||
| } | ||
|
|
||
| impl From<Options> for Settings { | ||
| fn from(options: Options) -> Self { | ||
| Self { | ||
| hardcoded_tmp_directory: options | ||
| .hardcoded_tmp_directory | ||
| .unwrap_or_else(default_tmp_dirs) | ||
| .into_iter() | ||
| .chain( | ||
| options | ||
| .hardcoded_tmp_directory_extend | ||
| .unwrap_or_default() | ||
| .into_iter(), | ||
| ) | ||
| .collect(), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl From<Settings> for Options { | ||
| fn from(settings: Settings) -> Self { | ||
| Self { | ||
| hardcoded_tmp_directory: Some(settings.hardcoded_tmp_directory), | ||
| hardcoded_tmp_directory_extend: None, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl Default for Settings { | ||
| fn default() -> Self { | ||
| Self { | ||
| hardcoded_tmp_directory: default_tmp_dirs(), | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.