🤖 Merge PR DefinitelyTyped#46067 feat(angular-bootstrap-lightbox): up…

…date types by @elpddev * feat(angular-bootstrap-lightbox): update types * feat(angular-bootstrap-lightbox): fix version * feat(angular-bootstrap-lightbox): fix general type
astorije · Jul 30, 2020 · 078cac4 · 078cac4
1 parent 072763f
commit 078cac4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/types/angular-bootstrap-lightbox/angular-bootstrap-lightbox-tests.ts b/types/angular-bootstrap-lightbox/angular-bootstrap-lightbox-tests.ts
@@ -14,6 +14,7 @@ imageList.push({
 
 var lightBox:angular.bootstrap.lightbox.ILightbox = <any> {};
 lightBox.openModal(imageList, 0);
+lightBox.openModal(imageList, 0, {});
 
 var provider:angular.bootstrap.lightbox.ILightBoxProvider = <any> {};
 provider.templateUrl = 'templateUrl';

diff --git a/types/angular-bootstrap-lightbox/index.d.ts b/types/angular-bootstrap-lightbox/index.d.ts
@@ -1,4 +1,4 @@
-// Type definitions for angular-bootstrap-lightbox
+// Type definitions for angular-bootstrap-lightbox 0.12
 // Project: https://github.com/compact/angular-bootstrap-lightbox
 // Definitions by: Roland Zwaga <https://github.com/rolandzwaga>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
@@ -40,7 +40,11 @@ declare namespace angular.bootstrap.lightbox {
     }
 
     export interface ILightbox {
-        openModal(images:ILightboxImageInfo[], index:number):void;
+        openModal(
+            images:ILightboxImageInfo[],
+            index:number,
+            modalParams?: { [key: string]: any }, // angular.ui.bootstrap.IModalSettings
+        ):void;
     }
 
     export interface ILightBoxProvider {