Add transform to load and import external CDN assets into the assetgraph root #229
+381
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can stub the CDN assets out with unexpected-mitm, see the http resolver tests. Parts of this could also be relevant for SourceMappingURL/SourceURL pointing to an external asset, and for the SRI support where we need to compute hashes of the external assets. We'll need to refine a lot of the queries in buildProduction to do the right thing. |
papandreou
reviewed
Oct 9, 2016
|
Good point. I'll look into that. How the heck does this PR drop code coverage by 5%? |
papandreou
reviewed
Oct 9, 2016
| // 'HtmlResourceHint', | ||
| // 'HtmlScript', | ||
| 'HtmlSearchLink', | ||
| // 'HtmlServiceWorkerRegistration', |
There was a problem hiding this comment.
Should be blacklisted as well.
| // 'HtmlFluidIconLink', | ||
| 'HtmlFrame', | ||
| 'HtmlIFrame', | ||
| 'HtmlIFrameSrcDoc', |
There was a problem hiding this comment.
Not necessary to list as it's a "born" inline relation.
…ring the rtransform
…n discovery and enable HtmlIframeSrcDoc according to PR feedback
|
Updated according to feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs assetgraph/assetgraph-builder#148
@papandreou This is very basic in that it only imports CSS and JavaScript. Might want to add web components as well. The test are running a bit slow, do you have any tricks to stub out the CDN assets?