Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript declarations with typescript compiler #1053

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

Munter
Copy link
Member

@Munter Munter commented Sep 10, 2019

Here's another take on getting type inference, checks and type definitions. This time using typescripts jsdoc support. See https://dev.to/open-wc/generating-typescript-definition-files-from-javascript-5bp2

Upsides:

  • Much better inference and completion in vscode
  • Linter feedback
  • Seemingly more complete types output

Downsides:

  • I can't make it not check node_modules
  • The only way to reference types defined in other files is breaking jsdoc generation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant