Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise required Java version to 17 #3447

Draft
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Draft

Raise required Java version to 17 #3447

wants to merge 2 commits into from

Conversation

scordio
Copy link
Member

@scordio scordio commented Apr 25, 2024

Warning

Targeting 3.x temporarily as main should be rebased after 3.26.0 is released.

This change moves the module descriptor of the core module to its main sources and removes the additional compiler execution. However, the module path is ignored when compiling the core module, executing its tests, and generating its Javadoc.

Closes #3442.

Co-authored-by: Andres Almiray <aalmiray@users.noreply.github.com>
Co-authored-by: Raphael Jenni <RaphaelJenni@users.noreply.github.com>
Co-authored-by: Simon Harte <SimonHarte@users.noreply.github.com>

@scordio scordio added this to the 4.0.0 milestone Apr 25, 2024
@scordio scordio changed the base branch from 3.x to main April 25, 2024 19:34
Copy link

github-actions bot commented Apr 25, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@scordio scordio force-pushed the java-17 branch 2 times, most recently from 46aeddf to 06b081d Compare April 25, 2024 23:48
@scordio scordio marked this pull request as draft April 25, 2024 23:53
This change moves the module descriptor of the core module to its main
sources and removes the additional compiler execution. However, the
module path is ignored when compiling the core module, executing its
tests, and generating the Javadoc.

Co-authored-by: Andres Almiray <aalmiray@users.noreply.github.com>
Co-authored-by: Raphael Jenni <RaphaelJenni@users.noreply.github.com>
Co-authored-by: Simon Harte <SimonHarte@users.noreply.github.com>
@scordio scordio changed the base branch from main to 3.x May 15, 2024 22:06
@scordio scordio force-pushed the java-17 branch 2 times, most recently from f0c859d to 1fb66f0 Compare May 15, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to Java 17
1 participant