Fix javadoc options / Use legacy mode to overcome <source> level issue #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix assertj#3392 (cherry picked from commit acd282b)
(cherry picked from commit 39e6bda)
Fix assertj#3433 Author: Lim Wonjae (cherry picked from commit 3cf3900)
Fix assertj#3401 (cherry picked from commit f086a92)
Fix assertj#3341 (cherry picked from commit ba02181)
…ert and remove Booleans internal class (cherry picked from commit 35e85a2)
|
Hi @hazendaz, sorry for getting back to you so late! Some of your changes have been applied as part of #3324. Still, I would apply the changes for However, I'm unsure if |
scordio
added a commit
that referenced
this pull request
May 10, 2024
Cherry-picked from #3231. Co-authored-by: Jeremy Landis <hazendaz@users.noreply.github.com>
…lues of the map (fix assertj#3291) (cherry picked from commit ded8fd8)
option needed to have additional arguments, removed old source 8 on javadocs as no longer needed here.
hazendaz
force-pushed
the
main
branch
2 times, most recently
from
6177af8
to
ec03b22
Compare
|
closing this, will open new one separately against main. |
|
@scordio How exactly is modular path excluded? Javadoc have always ran modular checks. The legacyMode flag (poorly named) disables that. |
|
Rebased this and created new PR to main since this got switched to 3.x since last time it was worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<legacyMode>which overcomes bugs with javadocs that prevented source from being set higher as documented here. To replace the source attribute this is set to 'true'