Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map entry values handle deep equality comparison again #2265

Merged
merged 4 commits into from Jun 17, 2021
Merged

Map entry values handle deep equality comparison again #2265

merged 4 commits into from Jun 17, 2021

Commits on Jun 17, 2021

  1. Map entry values handle deep equality comparison again 

    This appears to have broken in PR assertj#2167 specifically with the use of
`Map.remove(Object, Object)` that does not perform deep equality
checking on the map entry value (e.g. arrays).
    @schlosna
    schlosna committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    bc359bc View commit details
    Browse the repository at this point in the history

  2. reuse containsEntry

    @schlosna
    schlosna committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    3fd9a55 View commit details
    Browse the repository at this point in the history

  3. Move test to Maps_assertContainsOnly_Test

    @scordio
    scordio committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    7be0b1c View commit details
    Browse the repository at this point in the history

  4. Keep more verbose implementation for mapWithoutExpectedEntries

    @scordio
    scordio committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    535fd08 View commit details
    Browse the repository at this point in the history