Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catchThrowableOfType enriched alternatives #2410

Merged
merged 3 commits into from Dec 31, 2021
Merged

Conversation

Spacca
Copy link
Contributor

@Spacca Spacca commented Nov 14, 2021

Check List:

Added javadoc for the new catch***Exception methods
Added enriched alternatives for catchThrowableOfType
@scordio
Copy link
Member

scordio commented Nov 15, 2021

Thanks for the PR @Spacca. I see you added catch versions for additional exception types, which could be totally fine from my perspective. We may want to align the corresponding assertThat...Exception methods, probably in a separate PR.

What do you think @joel-costigliola?

@scordio scordio self-assigned this Dec 5, 2021
@joel-costigliola
Copy link
Member

We do want to align with assertThat...Exception, probably in a different issue, in the new issue we could also add a test to verify that we have matching assertThat...Exception with catch...Exception.

@scordio scordio added this to the 3.22.0 milestone Dec 17, 2021
@scordio scordio merged commit 6cd5811 into assertj:main Dec 31, 2021
@scordio
Copy link
Member

scordio commented Dec 31, 2021

Thanks for your first contribution, @Spacca!

@scordio scordio changed the title issue-2397 catchThrowableOfType enriched alternatives Add catchThrowableOfType enriched alternatives Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catchThrowableOfType enriched alternatives
3 participants