Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional assertThat...Exception and then...Exception alternatives #2454

Closed
scordio opened this issue Jan 1, 2022 · 2 comments
Closed

Additional assertThat...Exception and then...Exception alternatives #2454

scordio opened this issue Jan 1, 2022 · 2 comments
Assignees
@nannany
Labels
status: ideal for contribution An issue that a contributor can help us with
Milestone
3.23.0

Comments

@scordio
Copy link
Member

scordio commented Jan 1, 2022 •
edited

Summary

#2410 added some catchThrowable alternatives:

  • catchException
  • catchIndexOutOfBoundsException
  • catchReflectiveOperationException
  • catchRuntimeException

These do not have the corresponding Assertions.assertThat...Exception, WithAssertions.assertThat...Exception and BDDAssertions.then...Exception static methods.

We should add them and create a sync test between the three classes.
@scordio scordio added the status: ideal for contribution An issue that a contributor can help us with label Jan 1, 2022
@nannany
Copy link
Contributor

nannany commented Jan 4, 2022

Could you assign this issue to me as my first contribution?

@scordio
Copy link
Member Author

scordio commented Jan 4, 2022

Sure and thanks, @nannany!

@nannany nannany mentioned this issue Jan 10, 2022
Closed
@joel-costigliola joel-costigliola added this to the 3.23.0 milestone Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nannany nannany

Labels
status: ideal for contribution An issue that a contributor can help us with
Projects
None yet
Milestone
3.23.0
Development

Successfully merging a pull request may close this issue.

enriched assertThat...Exception and synced BDDAssertions, WithAssertions nannany/assertj-core
3 participants
@joel-costigliola @nannany @scordio