refactor(snapbox)!: Change as_bytes to to_bytes
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
requested changes
Jul 18, 2022
There was a problem hiding this comment.
I stopped part way through this. This PR completely removes the functions, changing them to their new variant even when that isn't the long term plan for those callers. I'd prefer this instead focus only only changing the long term call sites. If that means we do this after other PRs, I can go either way.
Muscraft
force-pushed
the
data-format-support
branch
from
a989b4e
to
4543940
Compare
Muscraft
changed the title
as_bytes to to_bytes and as_str to try_stringas_bytes to to_bytes
|
It looks like |
epage
changed the title
as_bytes to to_bytesas_bytes to to_bytes
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
as_bytestoto_bytesso we can write out to diskDataformats that will need more work to be serialized, like json.These changes were motivated by this comment