Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Report user value #117

Merged
merged 3 commits into from Nov 22, 2021
Merged

fix: Report user value #117

merged 3 commits into from Nov 22, 2021

Commits on Nov 22, 2021

  1. fix: Remove redundant result 

    We were showing the child predicate twice, one underneath the other,
because we both forwarded its `Display` *and* added `self` to the case
tree.
    @epage
    epage committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    afb25c6 View commit details
    Browse the repository at this point in the history

  2. fix: Clarify var vs expected

    @epage
    epage committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    7bf46b8 View commit details
    Browse the repository at this point in the history

  3. fix: Report user value 

    With some predicates, we show the user value (diff) but others do not.
This makes it more consistent.  We aim to show the user value in leaf
predicates and in major adapters.
- Some leaf predicates can't show a value (function)
- Some defer to a file on disk, so we leave it at that, in case the file
  is too big or ugly to shoe
- Simple adapters, like `trim` don't show.  So far, the only worthwhile
  one is `eq_file`.

By leaving things to the leaves, we are able to show the value after its
gone through transforms, like UTF-8, or loading a file path.

Fixes assert-rs#116
    @epage
    epage committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    beaf808 View commit details
    Browse the repository at this point in the history