Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory diff predicate #33

Open
epage opened this issue Apr 27, 2018 · 1 comment
Open

Directory diff predicate #33

epage opened this issue Apr 27, 2018 · 1 comment
Labels
enhancement Improve the expected
Milestone

Comments

@epage
Copy link
Contributor

epage commented Apr 27, 2018

Based on #32, let's provide a directory predicate.

What do we care about?

  • empty directories?
  • .keep files in directories
  • treating files as str
    • normalize line endings?
    • (with rich reporting) show a diff of files on failure?

How do we handle heterogeneous content?

  • Don't
  • dir-diff, filtering for the content we want, and run the dir-diff multiple times
  • A lambda
  • Accepting [[globs], Predicate]?

Additional resources

@epage epage added the enhancement Improve the expected label Apr 27, 2018
@epage epage added this to the 0.5 milestone Apr 27, 2018
@epage
Copy link
Contributor Author

epage commented Jul 1, 2018

Another angle to this: sometimes we'll want to make sure two directories are the same. Sometimes we don't want our "expected" to have to contain everything, so we'd want to only diff the subset of "expected" that is in "actual".

@epage epage mentioned this issue Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

1 participant