fix: Report user value #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were showing the child predicate twice, one underneath the other, because we both forwarded its `Display` *and* added `self` to the case tree.
With some predicates, we show the user value (diff) but others do not. This makes it more consistent. We aim to show the user value in leaf predicates and in major adapters. - Some leaf predicates can't show a value (function) - Some defer to a file on disk, so we leave it at that, in case the file is too big or ugly to shoe - Simple adapters, like `trim` don't show. So far, the only worthwhile one is `eq_file`. By leaving things to the leaves, we are able to show the value after its gone through transforms, like UTF-8, or loading a file path. Fixes assert-rs#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some predicates, we show the user value (diff) but others do not.
This makes it more consistent. We aim to show the user value in leaf
predicates and in major adapters.
is too big or ugly to shoe
trimdon't show. So far, the only worthwhileone is
eq_file.By leaving things to the leaves, we are able to show the value after its
gone through transforms, like UTF-8, or loading a file path.
Fixes #116