Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stdin): Provide a Command wrapper #85

Merged
merged 2 commits into from Dec 5, 2019
Merged

fix(stdin): Provide a Command wrapper #85

merged 2 commits into from Dec 5, 2019

Commits on Dec 5, 2019

  1. fix: More accurately name the cmd module 

    BREAKING CHANGE: `assert_cmd::cmd` was renamed to `assert_cmd::output`.
    Ed Page committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    15e40f6 View commit details
    Browse the repository at this point in the history

  2. fix(stdin): Provide a Command wrapper 

    Many of our problems with `stdin` are derived from using extension
traits. By moving away from them, we fix the API problems and make it
easier to add other features like timeout (assert-rs#10) or signalling (assert-rs#84).

So the new philosphy if:
- Core functionality is provided by extension traits
- Provide a convinience API that makes `Command` friendlier. These do
  not need to be generalized.  Other abstractions can provide their own
  (like `duct`).

Fixes assert-rs#73
    Ed Page committed Dec 5, 2019
    Configuration menu
    Copy the full SHA
    d159e87 View commit details
    Browse the repository at this point in the history