Skip to content
This repository has been archived by the owner on Jan 1, 2024. It is now read-only.

[Reverted] Use Redis#exists? and fallback to #exists which could be either boolean or integer in recent redis gem versions #382

Merged
merged 1 commit into from
Apr 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/vanity/adapters/redis_adapter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,13 @@ def get_experiment_completed_at(experiment)

def is_experiment_completed?(experiment) # rubocop:todo Naming/PredicateName
call_redis_with_failover do
@experiments.exists("#{experiment}:completed_at")
if @experiments.respond_to?(:exists?)
@experiments.exists?("#{experiment}:completed_at")
else
exists = @experiments.exists("#{experiment}:completed_at")

exists.is_a?(Numeric) ? exists > 0 : exists
end
end
end

Expand Down
2 changes: 1 addition & 1 deletion test/adapters/redis_adapter_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def stub_redis

it "gracefully fails in #is_experiment_completed?" do
redis_adapter, mocked_redis = stub_redis
mocked_redis.stubs(:exists).raises(RuntimeError)
mocked_redis.stubs(:exists?).raises(RuntimeError)

assert_silent do
redis_adapter.is_experiment_completed?("price_options")
Expand Down