Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added null check for remoteIpAdress in HttpContextClientInfoProvider.GetComputerName #6469

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Added null check for remoteIpAdress in HttpContextClientInfoProvider.GetComputerName #6469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Abp.AspNetCore/AspNetCore/Mvc/Auditing/HttpContextClientInfoProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
using System;
using Abp.Auditing;
using Abp.Auditing;
using Castle.Core.Logging;
using Microsoft.AspNetCore.Http;
using Abp.Extensions;
using System;
using System.Net;

namespace Abp.AspNetCore.Mvc.Auditing
Expand Down Expand Up @@ -56,8 +55,11 @@ protected virtual string GetComputerName()
try
{
var httpContext = _httpContextAccessor.HttpContext;
return Dns.GetHostEntry(httpContext?.Connection?.RemoteIpAddress).HostName;
var remoteIpAddress = httpContext?.Connection?.RemoteIpAddress;

if (remoteIpAddress is null) return null;

return Dns.GetHostEntry(remoteIpAddress).HostName;
}
catch (Exception ex)
{
Expand Down