Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Key Vault reading in AzureAppConfigurationBuilder (#230) #232

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Juraj2
Copy link

@Juraj2 Juraj2 commented Nov 16, 2023

  • Use GetCredential() for Key Vault readings and Add overload for SecretClientOptions in AzureAppConfigurationBuilder
  • This is fixing AzureAppConfigurationBuilder to read App Configuration Key-value references to Key Vault in the same way as AzureKeyVaultConfigBuilder

Addresses #230

…tClientOptions in AzureAppConfigurationBuilder (aspnet#230)

- Fix for AzureAppConfigurationBuilder to read App Configuration Key-value references to Key Vault in the same way as AzureKeyVaultConfigBuilder

Addresses aspnet#230
@Juraj2
Copy link
Author

Juraj2 commented Nov 16, 2023

@Juraj2 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@Juraj2 Juraj2 changed the title Use GetCredential() for Key Vault readings and Add overload for SecretClientOptions in AzureAppConfigurationBuilder (#230) Fix for Key Vault reading in AzureAppConfigurationBuilder (#230) Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant