Workaround high memory usage in binary logger #257
Conversation
build/KoreBuild.ps1
Outdated
|
|
||
| $msBuildArguments = @" | ||
| /nologo | ||
| /m | ||
| /p:RepositoryRoot="$repoFolder/" | ||
| /bl:"$msbuildLogFilePath" | ||
| "/logger:BinaryLogger,$sdkPath/Microsoft.Build.dll:$msbuildLogFilePath" |
There was a problem hiding this comment.
I think that should be a semicolon, not a colon
There was a problem hiding this comment.
Also should the full path to the .dll be in quotes? In case there's a space?
There was a problem hiding this comment.
Good catch. Windows machine is currently fried so I'm relying on CI + friends to tell me where I've messed up
|
LGTM just fix the colon and quotes. Did you try it locally? |
|
Passes locally on macos. @smitpatel look ok on Windows? |
|
It will take about half an hour for travis to produce results. I am uncertain about mac but Ubuntu has the worst performance around to an extent causing compile time failure. Let's just wait for EF build to finish. |
|
EF passed compilation phase. Good to go! |
| @@ -122,12 +122,14 @@ $msbuildArtifactsDir = "$repoFolder/artifacts/msbuild" | |||
| $msbuildLogFilePath = "$msbuildArtifactsDir/msbuild.binlog" | |||
| $msBuildResponseFile = "$msbuildArtifactsDir/msbuild.rsp" | |||
|
|
|||
| # Workaround https://github.com/Microsoft/msbuild/issues/2168 | |||
| $sdkPath = ((dotnet --info | sls 'Base Path') -split ':' | select-object -last 1).Trim() | |||
There was a problem hiding this comment.
We also have DotnetInstallationFolder\sdk\DotnetVersion\ to figure out this path. 😉
Either way is fine though.
|
Seems like formatting issue. |
|
Yes C: is missing and / is weird. |
|
splitting this |
|
Discussed with team. We're going to just turn it off for now. Closing in favor of #256 |
Workaround dotnet/msbuild#2168
cc @KirillOsenkov