Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider unifying our benchmark implementation with the TechEmpower one #1815

Open
roji opened this issue Mar 16, 2023 · 1 comment
Open

Comments

@roji
Copy link
Member

roji commented Mar 16, 2023

We currently have two implementations of e.g. TE platforms: one here, and one in the TechEmpower repo. The code is mostly the same, but there are some differences; this leads to constant laborious synchronization of the two, to keep them from diverging etc.

Why not have just a single source base, which we can sync by just copying code wholesale from here to there?

Note that there are two main data-related differences:

  • We have Dapper and EF, the TechEmpower code doesn't.
  • The TechEmpower code has MySQL (behind #ifs), we don't.

We can unify to have everything, but not necessarily run e.g. Dapper/EF at TechEmpower.

/cc @sebastienros @DamianEdwards

@roji roji changed the title Consider unifying out benchmark implementation with the TechEmpower one Consider unifying our benchmark implementation with the TechEmpower one Mar 16, 2023
@DamianEdwards
Copy link
Member

All in support of making it easier to keep our TechEmpower entries and this repo synced. I figure we'll do that as part of the work to deprecate the old benchmarks app implementation and replace it with the new individual apps.

@roji roji mentioned this issue Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants