Backport ASP.NET Core PKCE Support to OpenIdConnectAuthenticationHandler #389
+278
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport the ASP.NET Core PKCE implementation to the OWIN OpenIdConnect middleware.
Add basic PKCE related unit test. Port from ASP.NET Core.
|
Thanks for the PR, I should be able to look it over next week. FYI we don't have any releases scheduled for this product right now, there's no telling when this feature would be released. We've also temporarily disabled publishing the nightly builds due to an infrastructure change. |
|
No hurry. We have developed a workaround using the |
Tratcher
approved these changes
Dec 7, 2020
src/Microsoft.Owin.Security.OpenIdConnect/OpenIdConnectAuthenticationOptions.cs
Show resolved
Hide resolved
src/Microsoft.Owin.Security.OpenIdConnect/OpenidConnectAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
Adjust comment since RunAuthorizationCodeReceivedEventAsync only exists in Core.
Tratcher
approved these changes
Dec 10, 2020
src/Microsoft.Owin.Security.OpenIdConnect/OpenIdConnectAuthenticationOptions.cs
Outdated
Show resolved
Hide resolved
…icationOptions.cs
|
Thanks |
This was referenced Jun 6, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds PKCE Support to the OpenIdConnectAuthenticationHandler from #334
The implementation is a port from ASP.NET Core respecting some of the missing APIs:
https://github.com/dotnet/aspnetcore/blob/8a81194f372fa6fe63ded2d932d379955854d080/src/Security/Authentication/OpenIdConnect/src/OpenIdConnectHandler.cs#L386
and
https://github.com/dotnet/aspnetcore/blob/8a81194f372fa6fe63ded2d932d379955854d080/src/Security/Authentication/OpenIdConnect/src/OpenIdConnectHandler.cs#L1134
I've added some unit test to cover the challenge redirects and tested the implementation using the sandbox and IdentityServer4.
It could be possible to upgrade the IdentityModel.* packages as well. But I'm not aware if this would cause any braking changes.