chore: update swc v1.3.41 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realtimetodie
force-pushed
the
swc-v1.3.41
branch
from
8b56e84
to
75e5224
Compare
alexeagle
reviewed
Mar 20, 2023
swc/private/versions.bzl
Outdated
| "win32-ia32-msvc": "sha384-bEFBM1JCRTqtqx2jIVjF3PVyHRk84RWsAPR1asCVhcNMzvz1VDd6Ydtq2KR4K5v1", | ||
| "win32-x64-msvc": "sha384-wz5LmUtrIr3Qfy9yKbYWX+N2CqdmDyoe7OTnOkYaMR5s1v/e4s4BVrjFjQqkwcex", | ||
| }, | ||
| "v1.3.25": { |
There was a problem hiding this comment.
very few users are on windows, and removing all of these is a breaking change for them. Now that we are in an RC, we should avoid breaking changes.
alexeagle
reviewed
Mar 20, 2023
swc/repositories.bzl
Outdated
| @@ -98,7 +98,7 @@ def _determine_version(rctx): | |||
|
|
|||
| def _swc_repo_impl(repository_ctx): | |||
| version = _determine_version(repository_ctx) | |||
| if not versions.is_at_least("1.3.25", version.lstrip("v")): | |||
| if not versions.is_at_least("1.3.41", version.lstrip("v")): | |||
There was a problem hiding this comment.
we could make the minimum version conditional on whether you're on windows.
Or just leave it alone, the tiny number of windows users can discover the need to upgrade by reading the release notes.
It was fixed upstream in swc-project/swc#7077
alexeagle
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an obsolete workaround for Windows (#141) that was resolved in swc-project/swc#7077.
This is a breaking change. Prior releases to v1.3.41 will not work with rules_swc on Windows anymore.
Related