-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to swc v1.3.36 #169
Conversation
As far as I remember, I was able to run the tests after I changed the rules_swc/examples/paths/.swcrc Line 7 in ec1228a
I think this needs to be set to |
Unfortunately that didn't work. |
{
"jsc": {
"parser": {
"syntax": "typescript"
},
"target": "es2021",
"baseUrl": "./src",
"paths": {
"@modules/*": ["./modules/*"]
}
},
"module": {
"type": "commonjs"
},
"sourceMaps": true
} And then you need to fix the test, the module resolution was changed
|
Thanks, @realtimetodie, that worked! @gregmagolan @alexeagle This is ready for review. |
|
The change to the |
The
--config
flag was renamed to--config-json
, so plugin support will only work with versions >= 1.3.36 going forward.@realtimetodie It looks like module path handling may have been broken by swc-project/swc#6930, do you understand what is going on here?