fix(windows): mimic an empty stdin input #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the stdin handle from waiting in an infinite loop for the read stream to finish Fixes aspect-build#141
alexeagle
reviewed
Jan 9, 2023
There was a problem hiding this comment.
Cool, I wonder which is simpler, always use run shell on all platforms or make this change conditional on being on windows. @gregmagolan wdyt?
|
Also we should have a link to some upstream bug this is working around |
|
yes, I will need some time to fill an upstream bug |
Note: even if the exec platform is linux, it's okay that a windows host creates a run_shell command as it works in both places. This avoids the cost of an extra shell process for each swc spawn for linux/darwin
alexeagle
force-pushed
the
fix-windows-stdin-handle
branch
from
c5b2d14
to
d37a4b1
Compare
alexeagle
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the stdin handle from waiting in an infinite loop for the read stream to finish
Fixes #141