fix relative import of mock module #554
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #549
Description
from mock import mock
is syntactically valid.Without this patch, this transforms to
from unittest.mock import mock
(syntactically invalid)With this patch, this line becomes
from unittest import mock
Details
This patch looks for the identifier
mock
in thenames
part of theImportFrom
AST node. Then, it handles this case in one of two ways:len(names) == 1
.a. rewrite the module:
mock
->unittest
len(names) > 1
.a. rewrite the module:
mock
->unittest.mock
b. remove the identifier
mock
from the list ofnames
.c. add import on a new line:
from unittest import mock