Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egui now has a new version which takes Arc #285

Merged
merged 2 commits into from Oct 14, 2022
Merged

egui now has a new version which takes Arc #285

merged 2 commits into from Oct 14, 2022

Conversation

bananaturtlesandwich
Copy link
Contributor

@bananaturtlesandwich bananaturtlesandwich commented Oct 13, 2022

also bumping to the next version also allows compatibility with crates such egui-gizmo and egui-notify which are commonly used in 3d tools

also bumping to the next version also allows compatibility with crates such egui-gizmo and egui-notify which are commonly used in tools
@asny
Copy link
Owner

asny commented Oct 14, 2022

Actually, I already tried to upgrade, but as you see in the CI checks, egui has a bug when compiling to webassembly. The bug has been fixed a while ago, but no new (minor) version has been released 🤷

@bananaturtlesandwich
Copy link
Contributor Author

ah ok gotcha so this won't happen until egui has a new version put out resolving the web compilation issue 👍

@asny
Copy link
Owner

asny commented Oct 14, 2022

At least I would prefer waiting until a new version of egui is put out. I had hoped it wouldn't take that long but it has been a few months. @emilk Any plans for a minor release?

I'll keep the PR open, we want to do this at some point 🙂

@asny asny reopened this Oct 14, 2022
@emilk
Copy link
Contributor

emilk commented Oct 14, 2022

Actually, I already tried to upgrade, but as you see in the CI checks, egui has a bug when compiling to webassembly. The bug has been fixed a while ago, but no new (minor) version has been released

This is actually a problem with with ahash and you can solve it by adding this to your Cargo.toml:

getrandom = { version = "0.2", features = ["js"] }

EDIT: I finally opened a PR to aHash to fix this: tkaitchuck/aHash#131

@asny
Copy link
Owner

asny commented Oct 14, 2022

Nice, I can live with that solution! Thanks a lot @emilk 👍 And thanks @bananaturtlesandwich for the contribution 👍

@asny asny merged commit d71423e into asny:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants