Prepare for upcoming pytest 7.0 deprecations (part 2) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows up asmeurer#42, we decided that using just `fspath` as the new parameter that users should use would be confusing because it is too close to `path` and also we have `fspath` already in some places of the pytest public API (see pytest-dev/pytest#9283). This PR updates the hook affected by this new change in pytest-dev/pytest#9363.
|
Thanks. Are there any more changes forthcoming or should I do a release with this? |
|
So far that's it, thanks! |
|
Btw a new release would be appreciated, sorry I wasn't clear (I meant that there are no forthcoming changes). |
|
4.0.5 release done. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up #42, we decided that using just
fspathas the newparameter that users should use would be confusing because it is too
close to
pathand also we havefspathalready in some places ofthe pytest public API (see pytest-dev/pytest#9283).
This PR updates the hook affected by this new change in pytest-dev/pytest#9363.