-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure support for Uint8Array #246
Changes from all commits
f9679e7
771f812
88696fd
a31298f
8478084
c4b6b03
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
// Karma configuration | ||
// Generated on Sat May 23 2020 18:02:48 GMT-0400 (Eastern Daylight Time) | ||
process.env.CHROME_BIN = require('puppeteer').executablePath() | ||
|
||
module.exports = function(config) { | ||
config.set({ | ||
|
@@ -64,7 +65,7 @@ module.exports = function(config) { | |
|
||
// start these browsers | ||
// available browser launchers: https://npmjs.org/browse/keyword/karma-launcher | ||
browsers: ['PhantomJS'], | ||
browsers: ['ChromeHeadless'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if use of PhantomJS is intentional or accidental. In case it's intentional I would love to learn the reasons. In case it was accidental - here is my rationale for switching. PhantomJS is suspended for about 2 years already. When I was writing tests it was giving me all kinds of weird errors for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, Chrome Headless might be better here. Thank you! |
||
|
||
|
||
// Continuous Integration mode | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately I'd want to get rid of
Buffer.concat
so that we can avoid conversion to Buffers at all. Meanwhile, I think this stop gap is fine. (Same with utf32).