Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on the swiftlint executable for tests. #174

Merged
merged 7 commits into from Sep 15, 2021
Merged

Don't rely on the swiftlint executable for tests. #174

merged 7 commits into from Sep 15, 2021

Conversation

dirtyhabits97
Copy link
Collaborator

CI is raising this error

expected no Exception, got #<Errno::ENOENT: No such file or directory - /home/travis/build/ashfurrow/danger-ruby-swiftlint/ext/swiftlint/bin/swiftlint> with backtrace:

It seems like it is trying to find the swiftlint executable to lint the renamed file. This line fixes it:

allow_any_instance_of(Swiftlint).to receive(:lint).and_return('')

Fixes #171

NicolasCombe5555
NicolasCombe5555 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@NicolasCombe5555 NicolasCombe5555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@dirtyhabits97
Copy link
Collaborator Author

The downloadSwiftlint.sh now works on linux too.
Works as expected on mac:

Screen Shot 2021-09-14 at 19 28 37

ashfurrow
ashfurrow approved these changes Sep 15, 2021
View reviewed changes
Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@ashfurrow ashfurrow merged commit 734cc76 into master Sep 15, 2021
@ashfurrow
Copy link
Owner

Since this fixes a problem on Linux, I've released this as version 0.29.4. Thanks again!

@ashfurrow ashfurrow deleted the fix/specs branch September 15, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfurrow ashfurrow ashfurrow approved these changes

@NicolasCombe5555 NicolasCombe5555 NicolasCombe5555 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI isn't passing
3 participants
@dirtyhabits97 @ashfurrow @NicolasCombe5555