Skip to content

Commit

Permalink
Stop pinning zipp by default in [pytest].pytest_plugins (pantsbui…
Browse files Browse the repository at this point in the history
…ld#11512)

Pip's new resolver now errors when a constraints.txt value != an explicit requirement, such as one provided via `[pytest].pytest_plugins`. This means that if a user has `zipp` in their constraints.txt, they must either pin to the old `2.1.0` or they must override the default for `[pytest].pytest_plugins`. Both are very non-obvious what to do.

We had pinned zipp as a convenience because it was unstable for some time, but it seems to have become more stable. It's been working robustly to use zipp 3.* in Toolchain. Now, this is likely to be much more of a gotcha and nuisance than a value-add to users. So, we stop pinning.

[ci skip-rust]
[ci skip-build-wheels]
  • Loading branch information
Eric-Arellano committed Feb 2, 2021
1 parent 31e540a commit 7a4952f
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions src/python/pants/backend/python/subsystems/pytest.py
Expand Up @@ -34,13 +34,10 @@ def register_options(cls, register):
"--pytest-plugins",
type=list,
advanced=True,
default=[
"pytest-cov>=2.10.1,<2.11",
# NB: zipp has frequently destabilized builds due to floating transitive versions
# under pytest.
"zipp==2.1.0",
],
help="Requirement strings for any plugins or additional requirements you'd like to use.",
default=["pytest-cov>=2.10.1,<2.11"],
help=(
"Requirement strings for any plugins or additional requirements you'd like to use."
),
)
register(
"--timeouts",
Expand Down

0 comments on commit 7a4952f

Please sign in to comment.