Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct kerl cleanup call in install callback #296

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

Stratus3D
Copy link
Member

Fixes #280

The cleanup command expects either a build name or the keyword all. I was passing in the asdf version, which kerl didn't understand. Passing in the build name like we do for the kerl install command fixes this.

Test:

$ ls ~/.asdf/plugins/erlang/kerl-home/builds
asdf_26.1.1 asdf_26.1.2 asdf_26.2   asdf_26.2.1

$ asdf install erlang 25.3.2.8
asdf_25.3.2.8 is not a kerl-managed Erlang/OTP installation
No build named asdf_25.3.2.8
Downloading 25.3.2.8 to /Users/trevorbrown/.asdf/downloads/erlang/25.3.2.8...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 99.8M  100 99.8M    0     0  6805k      0  0:00:15  0:00:15 --:--:-- 6885k
Extracting source code
Building Erlang/OTP 25.3.2.8 (asdf_25.3.2.8), please wait...
APPLICATIONS DISABLED (See: /Users/trevorbrown/.asdf/plugins/erlang/kerl-home/builds/asdf_25.3.2.8/otp_build_25.3.2.8.log)
 * jinterface     : Java compiler disabled by user
 * odbc           : ODBC library - link check failed

DOCUMENTATION INFORMATION (See: /Users/trevorbrown/.asdf/plugins/erlang/kerl-home/builds/asdf_25.3.2.8/otp_build_25.3.2.8.log)
 * documentation  : 
 *                  fop is missing.
 *                  Using fakefop to generate placeholder PDF files.

Erlang/OTP 25.3.2.8 (asdf_25.3.2.8) has been successfully built
Cleaning up compilation products for asdf_25.3.2.8
Cleaned up compilation products for asdf_25.3.2.8 under /Users/trevorbrown/.asdf/plugins/erlang/kerl-home/builds

# Build directory for 25.3.2.8 is not persisted
$ ls ~/.asdf/plugins/erlang/kerl-home/builds
asdf_26.1.1 asdf_26.1.2 asdf_26.2   asdf_26.2.1

@Stratus3D Stratus3D merged commit ef8f04b into master Jan 3, 2024
4 checks passed
@Stratus3D Stratus3D deleted the tb/fix-clean-call branch January 3, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kerl cleanup not actually running?
1 participant