Fixes #1096. Make Cell extend StructuralNode instead of ContentNode. #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertpanzer
force-pushed
the
fix-1096-cell-structuralnode
branch
from
51ad234
to
9f450dc
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
Fix the issue #1096.
Calling Document.findBy() should not result in a ClassCastException.
How does it achieve that?
Make Cell extend StructuralNode instead of ContentNode. That way the ClassCastException does not happen anymore since
Document.findBy()returns aList<StructuralNode>Are there any alternative ways to implement this?
Make
Document.findBy()return aList<ContentNode>. However, afaict, this doesn't make much sense.Are there any implications of this pull request? Anything a user must know?
No.
It's currently on the main branch which eventually results in the next major version.
However, according to https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html, it should even be possible to backport this to the current 2.x line and publish a new bugfix release.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1096