Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1082. Return empty list in DescriptionList.getBlocks() instead… #1083

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Fixes #1082. Return empty list in DescriptionList.getBlocks() instead… #1083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions asciidoctorj-core/src/main/java/org/asciidoctor/jruby/ast/impl/DescriptionListImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

import java.util.List;

import static java.util.Collections.emptyList;

public class DescriptionListImpl extends StructuralNodeImpl implements DescriptionList {

public DescriptionListImpl(IRubyObject delegate) {
Expand Down Expand Up @@ -39,7 +41,6 @@ public String convert() {

@Override
public List<StructuralNode> getBlocks() {
RubyArray rubyBlocks = (RubyArray) getRubyProperty("blocks");
return new RubyBlockListDecorator<>(rubyBlocks);
return emptyList();
}
}
3 changes: 1 addition & 2 deletions asciidoctorj-core/src/test/groovy/org/asciidoctor/WhenTheSourceShouldBeAccessed.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ That::
and should continue here'''
listItem.description.text == '''list item should show bar
and should continue here'''
list.blocks.size() == list.items.size()
list.items[0].description.source == list.blocks[0].description.source
list.blocks.size() == 0
}

def 'it should be possible to get the raw text from a table cell'() {
Expand Down