Skip to content

Commit

Permalink
bump minimum required Ruby version to 2.5 (PR #4341)
Browse files Browse the repository at this point in the history
  • Loading branch information
mojavelinux committed Aug 24, 2022
1 parent 48c3552 commit e709633
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
ruby: [jruby-9.3.4.0, '2.3', '2.7', '3.0', '3.1']
ruby: [jruby-9.3.7.0, '2.5', '2.7', '3.0', '3.1']
asciimath-version: [~]
pygments-version: ['~> 2.0']
rouge-version: [~]
Expand All @@ -45,13 +45,13 @@ jobs:
- os: macos-latest
ruby: '3.1'
- os: ubuntu-latest
ruby: '2.3'
ruby: '2.5'
asciimath-version: '~> 1.0.0'
- os: ubuntu-latest
ruby: '2.3'
ruby: '2.5'
pygments-version: '~> 1.2.0'
- os: ubuntu-latest
ruby: '2.3'
ruby: '2.5'
rouge-version: '~> 2.0.0'
- os: ubuntu-latest
ruby: '3.1'
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Compliance::
* Don't promote level-0 special section at start of document to document title (#4151)
* Disallow the use of dot (`.`) in the name of a named element attribute (#4147)
* Disallow the use of the left square bracket in an attribute list on formatted text (#4306)
* Drop support for Ruby < 2.5

Improvements::

Expand Down
4 changes: 2 additions & 2 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ If you're using AsciiDoc.py, see {url-docs}/asciidoctor/latest/migrate/asciidoc-

Asciidoctor works on Linux, macOS and Windows and requires one of the following implementations of {url-ruby}[Ruby]:

* CRuby (aka MRI) 2.3 - 3.0
* JRuby 9.1 - 9.2
* CRuby (aka MRI) 2.5 - 3.1
* JRuby 9.1 - 9.3
* TruffleRuby (GraalVM)

[CAUTION]
Expand Down
2 changes: 1 addition & 1 deletion asciidoctor.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Gem::Specification.new do |s|
s.homepage = 'https://asciidoctor.org'
s.license = 'MIT'
# NOTE required ruby version is informational only; it's not enforced since it can't be overridden and can cause builds to break
#s.required_ruby_version = '>= 2.3.0'
#s.required_ruby_version = '>= 2.5.0'
s.metadata = {
'bug_tracker_uri' => 'https://github.com/asciidoctor/asciidoctor/issues',
'changelog_uri' => 'https://github.com/asciidoctor/asciidoctor/blob/HEAD/CHANGELOG.adoc',
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/install/pages/supported-platforms.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Asciidoctor requires one of the following implementations of {url-ruby}[Ruby^].
|Supported Runtime |Supported Versions

|Ruby
|&#8805; 2.3
|&#8805; 2.5

|JRuby
|&#8805; 9.1
Expand Down
2 changes: 1 addition & 1 deletion test/helpers_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
expected_cause_message = %r/^(?:no such file to load|cannot load such file) -- does-not-exist$/
assert_equal expected_message, ex.message
assert_match expected_cause_message, ex.cause.message
if (ex.respond_to? :full_message) && !jruby?
if (ex.respond_to? :full_message) && !jruby? && (Gem::Version.new RUBY_VERSION) >= (Gem::Version.new '2.7.0')
assert_match %r/helpers\.rb.*in.*require_library/, ex.full_message
assert_match %r/(?:no such file to load|cannot load such file) -- does-not-exist/, ex.full_message
else
Expand Down

0 comments on commit e709633

Please sign in to comment.