Shell completions #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for clap bug: clap-rs/clap#1140 where the arg will always be displayed in the usage string.
arusahni
force-pushed
the
shell-completion
branch
from
dec9c2f
to
b02e6fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--completionsarg which, when supplied with one ofzsh,bash,fish. It will invoke Clap's completion generation function to make a script which can then be loaded by a shell to supply completions forgit-req.I also changed
REQUEST_IDto not use adefault_valuedue to an issue with Clap's usage definition: clap-rs/clap#1140Fixes #35