Don't use clap's default_value for args that take values.

Workaround for clap bug: clap-rs/clap#1140 where the arg will always be displayed in the usage string.
arusahni · Dec 28, 2019 · 59e6b52 · 59e6b52
1 parent 366d703
commit 59e6b52
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cli-flags.yml b/cli-flags.yml
@@ -36,7 +36,6 @@ args:
       help: Specify the remote to be used
       takes_value: true
       required: false
-      default_value: origin
   - REQUEST_ID:
       conflicts_with:
         - NEW_PROJECT_ID

diff --git a/src/main.rs b/src/main.rs
@@ -166,7 +166,8 @@ fn main() {
         .author(crate_authors!("\n"))
         .get_matches();
 
-    let remote_name = matches.value_of("REMOTE_NAME").unwrap();
+    // Not using Clap's default_value because of https://github.com/clap-rs/clap/issues/1140
+    let remote_name = matches.value_of("REMOTE_NAME").unwrap_or("origin");
 
     if let Some(project_id) = matches.value_of("NEW_PROJECT_ID") {
         set_project_id(remote_name, project_id);