Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdb #136

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix pdb #136

wants to merge 2 commits into from

Conversation

etrikp
Copy link
Contributor

@etrikp etrikp commented Feb 16, 2024

minAvailable and maxUnavailable are mutually exclusive, this fix handles that requirement,

@arttor
Copy link
Owner

arttor commented Feb 20, 2024

helmify does not validate input k8s manifests. It tries to convert any input to Helm template with the best effort. I am not sure that we should do exception for pdb here.

@etrikp-ec
Copy link

I'm fine with not doing any validation and instead just passing through what helmify gets. The fix here is mostly around correcting the template error

07b0719#diff-8760a54892606e12340f2e99b239fe386b23663d702e89ef26b0e0ec761942a4L23-L24

This is invalid from the start, so helmify is introducing invalid manifests by always passing minAvailable and maxUnavailable via the way the template is constructed.

I propose just removing the error logging so validation is not a concern, then include the template fix that ensures helmify does not make all PDB manifests it encounters invalid.

@arttor
Copy link
Owner

arttor commented Feb 22, 2024

oh, i see the problem now. thanks!

@arttor arttor self-requested a review February 22, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants