Add an option for enable/disable webhook for a standard operator generated by kubebuilder #102
Conversation
dashanji
force-pushed
the
add-enable-webhook-option
branch
from
4ae4f03
to
826e4c4
Compare
|
@arttor Hi, could you please take a look at this? Thanks. |
dashanji
force-pushed
the
add-enable-webhook-option
branch
from
826e4c4
to
b4f8439
Compare
|
Hi @dashanji, I am very sorry. Will only have time to check on the weekend. |
| volumeMounts := ` - mountPath: /tmp/k8s-webhook-server/serving-certs | ||
| name: cert | ||
| readOnly: true` | ||
| webhookPort := ` - containerPort: 9443 |
There was a problem hiding this comment.
is there a better way to handle webhooks? I've tried to search a couple of kubebuilder projects on GitHub and some of them are using different ports or yaml properties can be ordered differently so strings.ReplaceAll will not work in most cases.
There was a problem hiding this comment.
Thanks for catching out, It looks like we could use the regular expression to handle these cases.
There was a problem hiding this comment.
@arttor Does such design make sense to you?
There was a problem hiding this comment.
yes, regular expressions look promising.
|
Hi @arttor, could you please take a look at this? Thanks. |
dashanji
force-pushed
the
add-enable-webhook-option
branch
2 times, most recently
from
7c562c0
to
bcac65f
Compare
…nerated by kubebuilder. * Use regular expressions to match the containerPort of the webhook. Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
dashanji
force-pushed
the
add-enable-webhook-option
branch
from
bcac65f
to
d6f44f3
Compare
As titled. Fix #57.