Support passing in Graph.artifacts #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes
Graph.artifacts
a normal pydantic field, rather than aPrivateAttr
with a@property
getter. This means an existing set of Artifacts can be passed in directly (eg: when deserializing).This also fixes a bug where the
Graph.artifacts
(and thusProducers
/ structure of the graph) wasn't actually encoded into theGraph.fingerprint
. This wouldn't have broken builds since the snapshotting logic accounts for this in a similar way.Pydantic has some caveats with copying dict subclasses that needed working around (and will likely need more when v2 is ready), but those are relatively minor.
I'll need to follow this up to ensure that the
Graph.__enter__
logic (which populatesarti.context.graph
to allow resolving all of thepath_tags
in theStorage
s) is called, but that's a bit trickier until Pydantic supports post-init (where we have access toself
) - I'll probably just override__init__
(but hopefully in a way that preserves the nice autogenerated hints and what not 馃).Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Updated and expanded tests
Checklist: