New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeSystem.extends #250
Add TypeSystem.extends #250
Conversation
Signed-off-by: James Oswald <james.oswald@dynotx.com>
I need to figure out how to handle unresolved |
FYI: I created pydantic/pydantic#4249 to fix the unresolved |
Signed-off-by: Jacob Hayes <jacob.r.hayes@gmail.com>
Signed-off-by: James Oswald <james.oswald@dynotx.com>
Signed-off-by: James Oswald <james.oswald@dynotx.com>
Signed-off-by: Jacob Hayes <jacob.r.hayes@gmail.com>
Signed-off-by: Jacob Hayes <jacob.r.hayes@gmail.com>
Signed-off-by: Jacob Hayes <jacob.r.hayes@gmail.com>
Signed-off-by: Jacob Hayes <jacob.r.hayes@gmail.com>
Signed-off-by: Jacob Hayes <jacob.r.hayes@gmail.com>
Signed-off-by: Jacob Hayes <jacob.r.hayes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for working on this! I'm excited to use this very soon for the numpy->pandas type systems!
# Fix ForwardRefs in outer_type_, pending: https://github.com/samuelcolvin/pydantic/pull/4249 | ||
TypeSystem.__fields__["extends"].outer_type_ = tuple[TypeSystem, ...] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I added this to fix the "runtime type checking" done on inputs to our Model
s.
Codecov Report
@@ Coverage Diff @@
## golden #250 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 39 39
Lines 2450 2448 -2
Branches 512 513 +1
=========================================
- Hits 2450 2448 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: James Oswald <james.oswald@dynotx.com> Co-authored-by: Jacob Hayes <jacob.r.hayes@gmail.com> Signed-off-by: Jacob Hayes <jacob.r.hayes@gmail.com>
Description
Fixes #243
Type of change
How Has This Been Tested?
Added test_TypeSystem_extends.
Checklist: