New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Multiple Python Versions and py 3.10 support #116
Conversation
Codecov Report
@@ Coverage Diff @@
## golden #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1416 1394 -22
Branches 196 196
=========================================
- Hits 1416 1394 -22
Continue to review full report at Codecov.
|
4320ddb
to
3268fd4
Compare
3268fd4
to
ea55e62
Compare
ea55e62
to
fe3997e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna merge, but feel free to review if interested. 😄
Pydantic has some issues with string
ClassVar
s in py 3.9.8 (which bumped automatically for new CI runs) and 3.10. For now, I pinned CI to only require 3.9.7, but add 3.9.8 and 3.10.0 to the CI matrix. Hopefully the associated PR will be merged and prompt a pydantic release soon enough, but if not we can remove thefrom __future__ import annotations
and stringize only when necessary (mostly forward refs/cyclic imports).(I blindly pushed f567b38 directly to
golden
, but this PR fixes a few issues w/ that)