Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions cache mode to docker/build-push-action #47

Merged
merged 1 commit into from Aug 7, 2021
Merged

Add GitHub Actions cache mode to docker/build-push-action #47

merged 1 commit into from Aug 7, 2021
+12 −0

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Aug 7, 2021

@lopopolo lopopolo added A-build Area: CI build infrastructure. A-performance Area: Performance improvements and optimizations. labels Aug 7, 2021
@lopopolo lopopolo merged commit 6a0c9ef into trunk Aug 7, 2021
@lopopolo lopopolo deleted the docker-cache branch August 7, 2021 21:14
@lopopolo
Copy link
Member Author

lopopolo commented Aug 7, 2021

This didn't work. I didn't set separate scopes for each Dockerfile so the caches are clobbering each other.

Fix incoming.

lopopolo added a commit that referenced this pull request Aug 7, 2021
@lopopolo
Add scopes to Docker gha cache backend to ensure each build gets a un…
8c468e2 
…ique cache

Followup to #47.
@lopopolo lopopolo mentioned this pull request Aug 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-build Area: CI build infrastructure. A-performance Area: Performance improvements and optimizations.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lopopolo