Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update artichoke CLI to clap v4 #2196

Merged
merged 4 commits into from Sep 29, 2022
Merged

Update artichoke CLI to clap v4 #2196

merged 4 commits into from Sep 29, 2022

Commits on Sep 29, 2022

  1. Update artichoke CLI to clap v4 

    https://epage.github.io/blog/2022/09/clap4/

`--help` output is changed, so update the ui-test snapshots.
    @lopopolo
    lopopolo committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    3eca7b9 View commit details
    Browse the repository at this point in the history

  2. Remove comment about clap panicking on broken pipes 

    This was fixed in 3.x.

Still keep the helper function, since it gives us control over the call to
process::exit and the exit code.
    @lopopolo
    lopopolo committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    2294bc1 View commit details
    Browse the repository at this point in the history

  3. Let clap print its own errors to get colorized output

    @lopopolo
    lopopolo committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    addb8c8 View commit details
    Browse the repository at this point in the history

  4. Use iter::once instead of an array iter

    @lopopolo
    lopopolo committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    011f8f7 View commit details
    Browse the repository at this point in the history