Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): showCalendar no longer triggers if readOnly is true #42

Merged
merged 2 commits into from Oct 3, 2019

Conversation

benhancock-com
Copy link
Contributor

@benhancock-com benhancock-com commented Oct 1, 2019

This PR is a bug fix for issue #41. It ensures the date picker is not shown if the field is marked as readOnly.

What kind of change does this PR introduce?

It ensures the date picker is not shown if the field is marked as readOnly.

What is the current behavior?

Currently, when clicking on an input marked as readOnly, the date picker will still be displayed.

What is the new behavior?

Now, when clicking on an input marked as readOnly, the date picker will no longer be displayed.

Checklist:

  • Documentation (N/A)
  • Tests
  • Ready to be merged

@vercel
Copy link

vercel bot commented Oct 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@arthurdenner arthurdenner changed the base branch from master to develop October 1, 2019 09:57
@arthurdenner
Copy link
Owner

arthurdenner commented Oct 1, 2019

Hi @benhancockco, thanks for contributing to the project.

Even though it appears you have fixed the problem, the TravisCI is failing, therefore, I can't merge it.

Can you take a look at it, please?

@arthurdenner arthurdenner changed the base branch from develop to master October 1, 2019 10:46
@benhancock-com
Copy link
Contributor Author

It looks like the failing pipeline is unrelated to this change.

After a bit of digging, it looks like there was an issue with ESLint and object destructuring (eslint/eslint#12335). Upgrading kcd-scripts to 1.8.0 seems to resolve the issue.

I'll create a new PR to update the dependencies.

@arthurdenner
Copy link
Owner

arthurdenner commented Oct 2, 2019

@benhancockco, since I've merged #43, can you rebase and update this PR so that the build will run again and we check if it passes now?

@benhancock-com
Copy link
Contributor Author

Looks like we're good to go!

@arthurdenner arthurdenner merged commit cfc0010 into arthurdenner:master Oct 3, 2019
arthurdenner added a commit that referenced this pull request Oct 3, 2019
@arthurdenner
Copy link
Owner

🎉 This PR is included in version 1.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arthurdenner
Copy link
Owner

arthurdenner commented Oct 3, 2019

Thanks for helping on this, @benhancockco.

Just so you know, in case you're thinking about working on any other issues, I'm working on a new branch called tsdx that migrates the codebase to TypeScript, builds the component with tsdx and will be the first step to release a new major version of the library.

You can checkout to the branch and take a look at it if you want to, make suggestions, etc.

Best regards! 👋

arthurdenner added a commit that referenced this pull request Oct 3, 2019
@arthurdenner
Copy link
Owner

@all-contributors please add @benhancockco for code.

@allcontributors
Copy link
Contributor

@arthurdenner

I've put up a pull request to add @benhancockco! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants