Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: builds for ruby 3+ #669

Merged
merged 2 commits into from May 23, 2022
Merged

Conversation

ylecuyer
Copy link
Collaborator

Current builds for ruby 3+ are failing because of this error:

Failures:

  1) Koala::Facebook::GraphAPIMethods #graph_call the appsecret_proof option is enabled by default if an app secret is present
     Failure/Error: response = api(path, args, verb, options)

       #<Koala::Facebook::API:0x000056012ae8[25](https://github.com/arsduo/koala/runs/6555738033?check_suite_focus=true#step:5:26)c0 @access_token="*", @app_secret="mysecret"> received :api with unexpected arguments
         expected: ("/path", {}, "get", {:appsecret_proof=>true})
              got: ("/path", {}, "get", {:appsecret_proof=>true})
     # ./lib/koala/api.rb:47:in `graph_call'
     # ./spec/cases/graph_api_spec.rb:61:in `block (4 levels) in <top (required)>'

As far as I know this is linked to latest rspec updates and we need rspec/rspec-support#537 to be merged and released before we can use latest versions of rspec

For the moment I'm locking the rspec version to the latest one which was working flawlessly

@ylecuyer ylecuyer merged commit 9f9bfc0 into arsduo:master May 23, 2022
@ylecuyer ylecuyer deleted the fix-ruby3-builds-yle branch May 23, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant