Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow timezones to be created directly within arrow #969

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

systemcatch
Copy link
Collaborator

@systemcatch systemcatch commented Apr 29, 2021

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

WIP still lots to do but the basics are working.

>>> import arrow
>>> tz=arrow.timezone("Europe/London")
>>> tz
tzfile('/usr/share/zoneinfo/Europe/London')

closes #912

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #969 (b186602) into master (a2ebb7e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #969   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2237      2243    +6     
  Branches       439       439           
=========================================
+ Hits          2237      2243    +6     
Impacted Files Coverage Δ
arrow/__init__.py 100.00% <100.00%> (ø)
arrow/api.py 100.00% <100.00%> (ø)
arrow/factory.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ebb7e...b186602. Read the comment docs.

@systemcatch systemcatch marked this pull request as ready for review November 30, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create arrow timezone interface and wrapper
2 participants