Correct humanize behaviour with datetime.date objects

[skrakowi]

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

• 🧪 Added tests for changed code.
• 🛠️ All tests pass when run locally (run tox or make test to find out!).
• 📚 Updated documentation for changed code.
• ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Closes: #697

[jadchaar]

Hi @skrakowi, it seems like the CI build is still failing. Once that is fixed, we can take a look at the changes!

[skrakowi]

Hi @jadchaar, I forgot to import the factory library. I fixed it on my skrakowi/arrow library but I'm not quite sure how to resubmit a pull request or show the new changes. Do you see the factory library imported in arrow_tests.py?

[systemcatch]

Hi @skrakowi any changes you push to your PR branch will show up here, your factory import is present now. Just an FYI it's generally better practice to create separate feature branches on your fork rather than develop on the master branch.

The builds are failing due to a lack on coverage in arrow.py.

[skrakowi]

@systemcatch Ok thanks for letting me know and for the tip! I'll keep that in mind in the future.

The coverage has been changing based on different times throughout the day and I'm not quite sure how to get 100% coverage on these tests when they depend on the current timestamp. Do you have any thoughts?

[systemcatch]

@skrakowi

Here are few pointers on the circleci failures.

The new test is failing, it needs a deeper dive to understand why, from a quick glance I think the old behaviour is still occurring. I see you've added a regression test which is good, let's label it as such so others know what it's for in the future.

FAIL: test_oneday_date (tests.arrow_tests.ArrowHumanizeTests)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/crsmithdev/arrow/.tox/py38/lib/python3.8/site-packages/chai/chai.py", line 63, in wrapper

    func(self, *args, **kwargs)

  File "/home/travis/build/crsmithdev/arrow/tests/arrow_tests.py", line 1760, in test_oneday_date

    self.assertEqual(result, "a day ago")

AssertionError: '2 days ago' != 'a day ago'

- 2 days ago

? ^    -

+ a day ago

? ^

Regarding the lack of coverage, the lines that are being missed are https://github.com/crsmithdev/arrow/pull/726/files#diff-5d8eb9e97f8b648e4dae883cdce7b959R937-R942

I think if you fix the failing test coverage should sort itself out.

[systemcatch]

Replaced by #748