Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.15.0: More robust parsing and support for ordinal dates and 8601 basic format #655

Merged
merged 60 commits into from Sep 8, 2019
Merged

v0.15.0: More robust parsing and support for ordinal dates and 8601 basic format #655

merged 60 commits into from Sep 8, 2019

Conversation

jadchaar
Copy link
Member

@jadchaar jadchaar commented Sep 8, 2019 •
edited

jadchaar and others added 30 commits June 22, 2019 21:16
@jadchaar
started some fixes for get method
47445f9
@jadchaar
Current progress of fixing get
df49462
@jadchaar
Merge master
4fea9ea
@systemcatch
Create custom warning class for get changes
d69d16c
@jadchaar
More progress toward GET fixes
a50137f
@jadchaar
Merge in latest changes and further improvements to get
8d17963
@jadchaar
Reverted change to handling of Z string
12c1b4c
@jadchaar
Added a number of new formatting changes
b67c9e2
@jadchaar
Removed unnecessary helper functions in parser class and cleaned up s…
824b744 
…ome variable names
@jadchaar
Fixed bug with YY mapping to 20
dc2e6d2
@systemcatch
Add tests for .get() warnings and comment on current problems
955850c
@jadchaar
Added comments and tests
91d99d7
@jadchaar
Added comments and tests
cd9297f
@jadchaar
Fixed merging issues
6ab1c0b
@jadchaar
Fixed a number of parsing issues with a couple of regex tweaks and ad…
e3126c7 
…ditions
@jadchaar
Added unit tests and added cleanup/validation to datetimte string in …
f77e698 
…parse_iso
@jadchaar
Merge pull request #609 from jadchaar/regex-get-fixes
0b26c12 
Replace conditionals with regex
@jadchaar
Tweaked space and t divider checks and added a few more test inputs
4c331c7
@jadchaar
Split up recently added parse_iso and parse unit tests and removed fr…
08df568 
…om_parse_iso flag
@jadchaar
Merged master
f1f2581
@jadchaar
Fixed bugs with basic format and multiple subsecond tokens
7622b8b
@jadchaar
Added an extra french test
824a655
@jadchaar
Fixed an issue with the timestamp not strictly matching
188693d
@jadchaar
Added overflow error test to is_timestamp
e480ea0
@jadchaar
Attempt at fixing linting
3f1a3c9
@jadchaar
Added support for DDD and DDDD tokens in arrow.get()
87f63fb
@jadchaar
Cleaned up timestamp docs
a6995ba
@jadchaar
Added tests for new timestring changes
d4bcb73
@systemcatch
Add tests for DDD and DDDD tokens
6c8fbba
@jadchaar
Merge master
3fb6a33
jadchaar and others added 19 commits August 13, 2019 18:25
@jadchaar
Added a few comments
62e8ced
@systemcatch
Make error messages clearer and add extra DDDD test
46f30b2
@jadchaar
Fixed a critical bug with X token and float timestamps; revamped basi…
4e36c9a 
…c format to use regex
@jadchaar
Added tests and removed stripping of whitespace
6f13d10
@jadchaar
Merge branch 'master' into Version-0.15.0
ed75554
@jadchaar
Merge version 0.15.0 branch
211206e
@jadchaar
Increment version
d9cb79e
@jadchaar
Fixed float timestamp on py27, removed warnings, changed parser error…
d7e083b 
… to inherit from value error
@jadchaar
Added tests and cleaned up TODOs
992038d
@jadchaar
Added ordinal tests and added new error type to fix exception bubblin…
fca6522 
…g issue with ordinal dates
@jadchaar
Consolidate and clean up errors for spacing
d63fd39
@jadchaar
Consolidate and clean up errors for spacing
e998373
@jadchaar
Cleaned up a comment
9940542
@jadchaar
Reverted version increment; added tests to get coverage to 100%
66d09f8
@jadchaar
Removed mixing of formatS
32fe0a5
@jadchaar
Changed checking of basic time format
66e97fe
@jadchaar
Merge pull request #639 from jadchaar/tz-changes
4a1c4c1 
Updated regular expressions, fixed a few bugs, added tests for v0.15.0
@jadchaar
Merged master and resolve conflicts
b9668a4
@jadchaar
Upgraded pre-commit packages
9aa2cb5
@codecov-io
Copy link

codecov-io commented Sep 8, 2019 •
edited

Codecov Report

Merging #655 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #655   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines        1548   1536   -12     
  Branches      237    244    +7     
=====================================
- Hits         1548   1536   -12
Impacted Files Coverage Δ
arrow/factory.py 100% <ø> (ø) ⬆️
arrow/parser.py 100% <100%> (ø) ⬆️
arrow/util.py 100% <100%> (ø) ⬆️
arrow/arrow.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877debf...3160c4c. Read the comment docs.

systemcatch
systemcatch approved these changes Sep 8, 2019
View reviewed changes
Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jadchaar jadchaar merged commit 2344c11 into master Sep 8, 2019
@jadchaar jadchaar changed the title Version 0.15.0 changes v0.15.0: More robust parsing and support for ordinal dates and 8601 basic format Sep 8, 2019
@jadchaar jadchaar changed the title v0.15.0: More robust parsing and support for ordinal dates and 8601 basic format More robust parsing and support for ordinal dates and 8601 basic format Sep 8, 2019
@jadchaar jadchaar changed the title More robust parsing and support for ordinal dates and 8601 basic format v0.15.0: More robust parsing and support for ordinal dates and 8601 basic format Sep 8, 2019
@jadchaar jadchaar deleted the Version-0.15.0 branch September 8, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systemcatch systemcatch systemcatch approved these changes

@crsmithdev crsmithdev Awaiting requested review from crsmithdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jadchaar @codecov-io @systemcatch