Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locale argument for factory.get() #631

Merged
merged 1 commit into from Aug 8, 2019

Conversation

charlax
Copy link
Contributor

@charlax charlax commented Aug 7, 2019

Fixes #630

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #631 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #631   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines        1513   1513           
  Branches      226    226           
=====================================
  Hits         1513   1513
Impacted Files Coverage Δ
arrow/factory.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14a355...b12b9f0. Read the comment docs.

@jadchaar
Copy link
Member

jadchaar commented Aug 8, 2019

Thanks for the contribution @charlax. This is a bug that resulted from adding support for kwargs in the get() function in version 0.14.3.

Honestly, I am very surprised that we lacked a test for this type of scenario.

@systemcatch looks good to me, but I'd like a second set of eyes since I am a bit tired!

@systemcatch systemcatch self-requested a review August 8, 2019 12:30
@systemcatch systemcatch changed the title Fix locale argument to get Fix locale argument for factory.get() Aug 8, 2019
Copy link
Collaborator

@systemcatch systemcatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @charlax!

@systemcatch systemcatch merged commit f872d7a into arrow-py:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: __init__() got an unexpected keyword argument 'locale'
4 participants