Python2.7 functools_lru_cache above 1.3 not working #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Python 2.7 backports.functools-lru-cache is not working from version 1.4 and up
Python2.7 functools_lru_cache above 1.3 not working
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 14
Lines 3385 3385
Branches 235 235
=====================================
Hits 3385 3385Continue to review full report at Codecov.
|
As suggested in arrow-py#495 adds support for Python 2.6 and lower
|
@wilmardo Is this still occurring for you? Does this issue occur also when running the arrow tests or only when installed and using from PyPI? |
|
Hey Wilmardo, thanks for this PR, but I am going to close it until we have full confirmation of the issue occurring in #495. @systemcatch and I are thinking it could be an issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495
When using Python 2.7 a not working
backports.functools-lru-cacheis getting installed.backports.functools-lru-cacheabove 1.3 gives an import error. This PR pins the required version between 1.2.1 and <1.4 and gets it working for now.This issue wasn't failing tests because the in the
requirements.txtthe version is pinned to 1.2.1 but that wasn't the case insetup.py.Corrected this with the second commit.
This issue seems to have something to do with this issue over at
jaraco/backports.functools-lru-cache.Reopened the issue and waiting for a response but this hotfixes the issue for now 馃憤