Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functools-lru-cache to setup #496

Merged

Conversation

ramonsaraiva
Copy link
Contributor

@ramonsaraiva ramonsaraiva commented Nov 25, 2017

#495

This PR dynamically adds 'backports.functools_lru_cache==1.2.1' to install_requires if python version is less than 3.

This is urgent cause arrow is broken in py2.x versions.

@codecov-io
Copy link

Codecov Report

Merging #496 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #496   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        3189   3189           
  Branches      229    229           
=====================================
  Hits         3189   3189

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b4f4c...62c5312. Read the comment docs.

@crsmithdev crsmithdev merged commit 4705ede into arrow-py:master Nov 25, 2017
@FRidh
Copy link

FRidh commented Dec 30, 2017

Why is a specific patch release needed? Can't it work with any 1.2? Fixing to a patch release is bad practice. Also, why not allow the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants